git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/7] Extract, test and enhance the logic to collapse ../foo paths.

From
EWEric Wong <normalperson@yhbt.net>
Date
Sep 26, 2012, 20:58 UTC
Message-ID
<20120926205851.GA2166@dcvr.yhbt.net>
In-Reply-To
<20120926194504.GA5013@elie.Belkin>
Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 17 quoted lines
> Hi,
> 
> Michael G Schwern wrote:
> > On 2012.7.30 12:51 PM, Eric Wong wrote:
> >> Michael G Schwern wrote:
> 
> >>> _collapse_dotdot() works better than the existing regex did.
> >>
> >> I don't dispute it's better, but it's worth explaining in the commit
> >> message to reviewers why something is "better".
> >
> > Yeah.  I figured the tests covered that.
> 
> Now I'm tripping up on the same thing.  Eric, did you ever find out
> what the motivation for this patch was?  Is SVN 1.7 more persnickety
> about runs of multiple slashes in a row or something, or is it more
> of an aesthetic thing?

I'm not sure about this case specifically, but SVN has (and will likely become) more persnickety over time. I haven't had a chance to check SVN itself, but I think being defensive and giving it prettier paths will be safer in the future.

That said, I'd favor an implementation that split on m{/+} and collapsed as Michael mentioned.

Previous: Jonathan NiederNext: Jonathan Nieder
Message 19 of 39 in “Canonicalize the git-svn path & url accessors”
  1. Michael G. SchwernJul 28, 2012
  2. 1/7 Move the canonicalization functions to Git::SVN::UtilsMichael G. Schwern, Jul 28, 2012
  3. 2/7 Change canonicalize_url() to use the SVN 1.7 API when available.Michael G. Schwern, Jul 28, 2012
  4. Jonathan NiederJul 28, 2012
  5. Michael G SchwernJul 28, 2012
  6. Jonathan NiederJul 28, 2012
  7. Michael G SchwernJul 28, 2012
  8. Jonathan NiederJul 28, 2012
  9. Jonathan NiederJul 28, 2012
  10. Michael G SchwernJul 28, 2012
  11. 0/2 Re: [PATCH 2/7] Change canonicalize_url() to use the SVN 1.7 API when available.Jonathan Nieder, Oct 14, 2012
  12. 1/2 git svn: do not overescape URLs (fallback case)Jonathan Nieder, Oct 14, 2012
  13. 2/2 git svn: canonicalize_url(): use svn_path_canonicalize when availableJonathan Nieder, Oct 14, 2012
  14. Eric WongOct 23, 2012
  15. 3/7 Extract, test and enhance the logic to collapse ../foo paths.Michael G. Schwern, Jul 28, 2012
  16. Eric WongJul 30, 2012
  17. Michael G SchwernJul 30, 2012
  18. Jonathan NiederSep 26, 2012
  19. Eric WongSep 26, 2012
  20. Jonathan NiederSep 26, 2012
  21. Eric WongSep 26, 2012
  22. Jonathan NiederSep 26, 2012
  23. Eric WongSep 27, 2012
  24. Jonathan NiederSep 27, 2012
  25. 4/7 Add join_paths() to safely concatenate paths.Michael G. Schwern, Jul 28, 2012
  26. Jonathan NiederSep 26, 2012
  27. 5/7 Remove irrelevant comment.Michael G. Schwern, Jul 28, 2012
  28. 6/7 Switch path canonicalization to use the SVN API.Michael G. Schwern, Jul 28, 2012
  29. Jonathan NiederJul 28, 2012
  30. Michael G SchwernJul 28, 2012
  31. Eric WongJul 30, 2012
  32. Eric WongAug 2, 2012
  33. Michael G SchwernAug 2, 2012
  34. git-svn: keep leading slash when canonicalizing paths (fallback case)Jonathan Nieder, Oct 5, 2012
  35. Eric WongOct 5, 2012
  36. Junio C HamanoOct 6, 2012
  37. 7/7 Make Git::SVN and Git::SVN::Ra canonicalize paths and urls.Michael G. Schwern, Jul 28, 2012
  38. Jonathan NiederJul 28, 2012
  39. Michael G SchwernJul 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.