git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] gitk: Synchronize highlighting in file view when scrolling diff

From
Paul Mackerras <paulus@samba.org>
Date
Sep 23, 2012, 06:58 UTC
Message-ID
<20120923065825.GA15889@bloggs.ozlabs.ibm.com>
In-Reply-To
<1348078647-22516-1-git-send-email-stefan@haller-berlin.de>
On Wed, Sep 19, 2012 at 08:17:27PM +0200, Stefan Haller wrote:
Show 9 quoted lines
> Here's one way how to address your concern. When pressing the search button
> it will highlight the file that contains the current search hit; if you then
> scroll from there though, the normal mechanism kicks in again and might
> highlight the previous file. The same happens now if you select the last file
> in the list, but it's diff is smaller than a screenful. In the previous
> patch versions it would select a different file than you clicked on, which
> is probably also confusing.
> 
> Is this what you had in mind?

Yes, it is, and I applied your patch. I wonder though if it might work better to highlight all the files that are visible?

Paul.
Previous: Stefan HallerNext: Stefan Haller
Message 7 of 10 in “gitk: Synchronize highlighting in file view when scrolling diff”
  1. gitk: Synchronize highlighting in file view when scrolling diffStefan Haller, Sep 18, 2012
  2. Peter OberndorferSep 18, 2012
  3. gitk: Synchronize highlighting in file view when scrolling diffStefan Haller, Sep 19, 2012
  4. Paul MackerrasSep 18, 2012
  5. Marc BranchaudSep 19, 2012
  6. gitk: Synchronize highlighting in file view when scrolling diffStefan Haller, Sep 19, 2012
  7. Paul MackerrasSep 23, 2012
  8. Stefan HallerSep 24, 2012
  9. gitk: Do not select file list entries during diff loadingPeter Oberndorfer, Oct 26, 2012
  10. Stefan HallerOct 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.