From: Paul Mackerras Date: Sun, 23 Sep 2012 06:58:25 GMT Subject: Re: [PATCH v3] gitk: Synchronize highlighting in file view when scrolling diff Message-ID: <20120923065825.GA15889@bloggs.ozlabs.ibm.com> In-Reply-To: <1348078647-22516-1-git-send-email-stefan@haller-berlin.de> On Wed, Sep 19, 2012 at 08:17:27PM +0200, Stefan Haller wrote: > Here's one way how to address your concern. When pressing the search button > it will highlight the file that contains the current search hit; if you then > scroll from there though, the normal mechanism kicks in again and might > highlight the previous file. The same happens now if you select the last file > in the list, but it's diff is smaller than a screenful. In the previous > patch versions it would select a different file than you clicked on, which > is probably also confusing. > > Is this what you had in mind? Yes, it is, and I applied your patch. I wonder though if it might work better to highlight all the files that are visible? Paul.