git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

From
Jeff King <peff@peff.net>
Date
Sep 17, 2012, 22:17 UTC
Message-ID
<20120917221710.GA555@sigill.intra.peff.net>
In-Reply-To
<7vd31ks3ls.fsf@alter.siamese.dyndns.org>
On Mon, Sep 17, 2012 at 03:10:07PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
> > But how far should this policy be taken?  It seems to me that strict
> > adherence to the policy would dictate that *.h files should *never*
> > include other git project files.
> 
> I wouldn't call that a "policy".  It's something we think about when
> adding a new "#include" to see if it is worth adding and/or if it is
> the right place to add it to reduce code churn.
> 
> As I said, what policy to pick and stick to is open to discussion,
> and I wanted to leave it outside the scope of this series.  As it
> has been cooking in 'next', I do not think it is worth reverting the
> inclusion of "string-list.h" to delay this topic.  It is something
> that can and should be cleaned up when we decide to pick the
> inclusion policy and enforce it.  If we choose to go in the other
> direction, we would end up adding it back, so let's keep it as-is
> for now.

I will admit that I usually follow the opposite policy of what you have suggested, and include dependent headers in the .h files. Mostly just because it makes things simpler for the user of the header file, and there aren't really downsides (yes, you can have weird dependency-order issues, but in practice those are rare, and they generate very obvious compile-time errors).

What I think would be much more productive is breaking apart gigantic includes like cache.h into more reasonable modules, which would mean less frequent recompilation when an uninteresting part of the header changes. But git is reasonably fast to compile as it is, so I have never quite decided that it is worth the human effort to go in that direction.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 32 in “Clean up how fetch_pack() handles the heads list”
  1. 00/14 Clean up how fetch_pack() handles the heads listMichael Haggerty, Sep 9, 2012
  2. 01/14 t5500: add tests of error output for missing refsMichael Haggerty, Sep 9, 2012
  3. 02/14 t5500: add tests of fetch-pack --all --depth=N $URL $REFMichael Haggerty, Sep 9, 2012
  4. Junio C HamanoSep 10, 2012
  5. Michael HaggertySep 10, 2012
  6. Philip OakleySep 18, 2012
  7. 03/14 Rename static function fetch_pack() to http_fetch_pack()Michael Haggerty, Sep 9, 2012
  8. 04/14 fetch_pack(): reindent function decl and defnMichael Haggerty, Sep 9, 2012
  9. 05/14 Change fetch_pack() and friends to take string_list argumentsMichael Haggerty, Sep 9, 2012
  10. Junio C HamanoSep 10, 2012
  11. Michael HaggertySep 17, 2012
  12. Junio C HamanoSep 17, 2012
  13. Jeff KingSep 17, 2012
  14. Junio C HamanoSep 18, 2012
  15. 06/14 filter_refs(): do not check the same sought_pos twiceMichael Haggerty, Sep 9, 2012
  16. 07/14 fetch_pack(): update sought->nr to reflect number of unique entriesMichael Haggerty, Sep 9, 2012
  17. 08/14 filter_refs(): delete matched refs from sought listMichael Haggerty, Sep 9, 2012
  18. 09/14 filter_refs(): build refs list as we goMichael Haggerty, Sep 9, 2012
  19. Junio C HamanoSep 10, 2012
  20. 10/14 filter_refs(): simplify logicMichael Haggerty, Sep 9, 2012
  21. 11/14 cmd_fetch_pack(): return early if finish_connect() failsMichael Haggerty, Sep 9, 2012
  22. 12/14 fetch-pack: report missing refs even if no existing refs were receivedMichael Haggerty, Sep 9, 2012
  23. 13/14 cmd_fetch_pack(): simplify computation of return valueMichael Haggerty, Sep 9, 2012
  24. 14/14 fetch-pack: eliminate spurious error messagesMichael Haggerty, Sep 9, 2012
  25. Junio C HamanoSep 9, 2012
  26. Jeff KingSep 9, 2012
  27. Junio C HamanoSep 9, 2012
  28. Michael HaggertySep 10, 2012
  29. Junio C HamanoSep 10, 2012
  30. Michael HaggertySep 17, 2012
  31. Junio C HamanoSep 17, 2012
  32. Junio C HamanoSep 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.