git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 02/14] t5500: add tests of fetch-pack --all --depth=N $URL $REF

From
Philip Oakley <philipoakley@iee.org>
Date
Sep 18, 2012, 23:37 UTC
Message-ID
<012B3B00ED9F48E5B0A8A4E21B944754@PhilipOakley>
In-Reply-To
<504E6141.1080306@alum.mit.edu>
From: "Michael Haggerty" <mhagger@alum.mit.edu>
Sent: Monday, September 10, 2012 10:53 PM
Show 16 quoted lines
> On 09/10/2012 10:46 PM, Junio C Hamano wrote:
>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>>
>>> Document some bugs in "git fetch-pack":
>>>
>>> 1. If "git fetch-pack" is called with "--all", "--depth", and an
>>> explicit existing non-tag reference to fetch, then it falsely
>>> reports
>>> that the reference was not found, even though it was fetched
>>> correctly.
>>>
>>> 2. If "git fetch-pack" is called with "--all", "--depth", and an
>>> explicit existing tag reference to fetch, then it segfaults in
>>> filter_refs() because return_refs is used without having been
>>> initialized.
>>

This probably isn't the right place in the series but I've just see a question on SO http://stackoverflow.com/questions/12475210/git-shallow-clone-along-with-branch which gives a user case that may or may not be covered by the pack-fetch.

The user was looking for 'git clone --depth 1 -b master' and comparing it to a plain 'git clone --depth 1' and to 'git clone -b master' with the follow up question "That is, why when passing -b it seems like it's changing behaviour of --depth ?"

Perhaps something to test out.
Philip
Previous: Michael HaggertyNext: Michael Haggerty
Message 6 of 32 in “Clean up how fetch_pack() handles the heads list”
  1. 00/14 Clean up how fetch_pack() handles the heads listMichael Haggerty, Sep 9, 2012
  2. 01/14 t5500: add tests of error output for missing refsMichael Haggerty, Sep 9, 2012
  3. 02/14 t5500: add tests of fetch-pack --all --depth=N $URL $REFMichael Haggerty, Sep 9, 2012
  4. Junio C HamanoSep 10, 2012
  5. Michael HaggertySep 10, 2012
  6. Philip OakleySep 18, 2012
  7. 03/14 Rename static function fetch_pack() to http_fetch_pack()Michael Haggerty, Sep 9, 2012
  8. 04/14 fetch_pack(): reindent function decl and defnMichael Haggerty, Sep 9, 2012
  9. 05/14 Change fetch_pack() and friends to take string_list argumentsMichael Haggerty, Sep 9, 2012
  10. Junio C HamanoSep 10, 2012
  11. Michael HaggertySep 17, 2012
  12. Junio C HamanoSep 17, 2012
  13. Jeff KingSep 17, 2012
  14. Junio C HamanoSep 18, 2012
  15. 06/14 filter_refs(): do not check the same sought_pos twiceMichael Haggerty, Sep 9, 2012
  16. 07/14 fetch_pack(): update sought->nr to reflect number of unique entriesMichael Haggerty, Sep 9, 2012
  17. 08/14 filter_refs(): delete matched refs from sought listMichael Haggerty, Sep 9, 2012
  18. 09/14 filter_refs(): build refs list as we goMichael Haggerty, Sep 9, 2012
  19. Junio C HamanoSep 10, 2012
  20. 10/14 filter_refs(): simplify logicMichael Haggerty, Sep 9, 2012
  21. 11/14 cmd_fetch_pack(): return early if finish_connect() failsMichael Haggerty, Sep 9, 2012
  22. 12/14 fetch-pack: report missing refs even if no existing refs were receivedMichael Haggerty, Sep 9, 2012
  23. 13/14 cmd_fetch_pack(): simplify computation of return valueMichael Haggerty, Sep 9, 2012
  24. 14/14 fetch-pack: eliminate spurious error messagesMichael Haggerty, Sep 9, 2012
  25. Junio C HamanoSep 9, 2012
  26. Jeff KingSep 9, 2012
  27. Junio C HamanoSep 9, 2012
  28. Michael HaggertySep 10, 2012
  29. Junio C HamanoSep 10, 2012
  30. Michael HaggertySep 17, 2012
  31. Junio C HamanoSep 17, 2012
  32. Junio C HamanoSep 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.