git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 2/3] Delete reflogs for dead references to allow pruning

From
Jeff King <peff@peff.net>
Date
Aug 21, 2012, 08:33 UTC
Message-ID
<20120821083345.GB13252@sigill.intra.peff.net>
In-Reply-To
<1345310086-20089-3-git-send-email-mhagger@alum.mit.edu>
On Sat, Aug 18, 2012 at 07:14:45PM +0200, mhagger@alum.mit.edu wrote:
Show 23 quoted lines
> From: Michael Haggerty <mhagger@alum.mit.edu>
> 
> This test is broken by "retain reflogs for deleted refs".  Explicitly
> delete the reflogs in the graveyard to allow the corresponding commits
> to be pruned.
> 
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
> 
> Probably there should be a "git reflog" subcommand to do this.
> 
>  t/t9300-fast-import.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
> index 266ae30..dc6c67d 100755
> --- a/t/t9300-fast-import.sh
> +++ b/t/t9300-fast-import.sh
> @@ -1700,6 +1700,7 @@ INPUT_END
>  
>  test_expect_success 'P: verbatim SHA gitlinks' '
>  	git branch -D sub &&
> +	rm -rf .git/logs/graveyard &&

I think "git reflog expire --expire=now refs/heads/sub" would be less leaky. That didn't work in my initial version, but it obviously should. I'll include a tweaked version of your fix when I re-roll.

-Peff
Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 4 of 21 in “[RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change”
  1. mhagger@alum.mit.eduAug 18, 2012
  2. 1/3 t9300: format test in modern style prior to modifying itmhagger@alum.mit.edu, Aug 18, 2012
  3. 2/3 Delete reflogs for dead references to allow pruningmhagger@alum.mit.edu, Aug 18, 2012
  4. Jeff KingAug 21, 2012
  5. 3/3 Change naming convention for the reflog graveyardmhagger@alum.mit.edu, Aug 18, 2012
  6. Junio C HamanoAug 18, 2012
  7. Alexey MuranovAug 18, 2012
  8. Junio C HamanoAug 19, 2012
  9. Alexey MuranovAug 19, 2012
  10. Alexey MuranovAug 19, 2012
  11. Alexey MuranovAug 19, 2012
  12. Junio C HamanoAug 19, 2012
  13. Alexey MuranovAug 19, 2012
  14. Junio C HamanoAug 20, 2012
  15. Junio C HamanoAug 20, 2012
  16. Alexey MuranovAug 20, 2012
  17. Alexey MuranovAug 20, 2012
  18. Michael HaggertyAug 19, 2012
  19. Junio C HamanoAug 19, 2012
  20. Jeff KingAug 21, 2012
  21. Junio C HamanoAug 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.