Re: Extract Git classes from git-svn (2/10) (was Re: Fix git-svn tests for SVN 1.7.5.)

Michael G Schwern <schwern@pobox.com> wrote:

Hi Michael, thanks for taking your time to help with this.

I agree with everything Jonathan said (and thank him for taking the time to point you in the right direction).

I too (very strongly) prefer email for code review. I doubt I would've ever gotten involved if git were run differently. I'm actually disappointed the mailing list culture that built git hasn't rubbed off to other projects that adopt git.

I prefer not declaring test counts and using done_testing() instead. done_testing() is favorable to me in at least 2 ways:

* done_testing() closely matches the behavior of the existing
  sh-based test suite in git (which calls test_done)

* maintaining test counts leads to unnecessary merge conflicts

Skipping the tests on old versions of Test::More (< 0.88) is acceptable to me (especially since integration tests provide the real coverage already).

no_plan is the worst way to use Test::More, I think.