Re: Fix git-svn tests for SVN 1.7.5.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 17, 2012, 17:44 UTC
Message-ID: <20120717174446.GA14244@burratino>
In-Reply-To: <5004B772.3090806@pobox.com>

Hi!

Michael G Schwern wrote:

> I've fixed the git-svn tests for SVN 1.7 and tested with SVN 1.7.5.

Thanks. git-svn is not maintained by Junio but by Eric and others on the list. I'm cc-ing Eric and Ben Walton so they can benefit from your work.

Show 26 quoted lines

>                                                                      SVN 1.7
> changed its expectations of path and URL formats and git-svn did not comply
> with them.  The new code uses SVN's own canonicalization routines where
> available.  This has been reported in several places...
> https://bugs.gentoo.org/show_bug.cgi?id=418431
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678764
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661094
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678137
> https://trac.macports.org/ticket/32753
>
> It also split the internal classes out of git-svn.perl and into their own
> modules in perl/Git/ to make them easier to work on.  They compile alone, but
> remain heavily intertwined with each other and git-svn.  I didn't want to go
> very far down that rabbit hole.
>
> This makes the tests pass, but I'm pretty sure plenty of canonicalization
> problems remain untested.  Hopefully by attacking the problem at the root (ie.
> in the Git::SVN and Git::SVN::Ra accessors) it will wipe out a range of problems.
>
> t9100-git-svn-basic.sh tests 11-13 continue to fail for what look like
> unrelated reasons to do with SVN and symlinks.
>
> There's a lot of work in this change, so I felt it better to submit the
> patches as a link to a git repository rather than attach a pile of patches.
> Here is my repository, the work is in the fix-canonical branch.
> https://github.com/schwern/git

It is indeed quite the intimidating pile of patches, so I do not think we will be able to apply it all in one chunk as-is. :(

My advice would be to send five or so of the patches that you would like to be reviewed first, inline, one per message, in reply to this message so we can start to work on that. Presumably the patches do not regress git-svn's behavior but only make it saner, so even if this is not a complete fix it should allow us to get started. See Documentation/SubmittingPatches for more hints.

Thanks and hope that helps, Jonathan