Re: [PATCH 3/6] t4012: Actually quote the sed script
Hi Zbigniew,
Zbigniew Jędrzejewski-Szmek wrote:
> On 07/12/2012 12:12 AM, Alexander Strasser wrote:
Show 6 quoted lines
> I have some spelling corrections (minor, but since you intend to re-roll
> anyway, I'll post them), and one more thing which could be corrected
> (below).
>
> 3/6: s/Never the less/Nevertheless/
> 4/6: s/masquerading/masking/ (masquerade means to "mask oneself")
Show 5 quoted lines
> > if git apply --stat --summary broken 2>detected
> > then
> > echo unhappy - should have detected an error
> I think this can be changed to:
> test_must_fail git apply --stat --summary broken 2>detected
Thank you for your sharp feedback. I will implement the requested
changes for the re-roll.
Alexander