From: Alexander Strasser <eclipse7@gmx.net>
Date: Thu, 12 Jul 2012 22:26:52 GMT
Subject: Re: [PATCH 3/6] t4012: Actually quote the sed script
Message-ID: <20120712222652.GB2782@akuma>
In-Reply-To: <4FFEBFE2.5030206@in.waw.pl>

Hi Zbigniew,

Zbigniew Jędrzejewski-Szmek wrote:
> On 07/12/2012 12:12 AM, Alexander Strasser wrote:
[...]
> I have some spelling corrections (minor, but since you intend to re-roll
> anyway, I'll post them), and one more thing which could be corrected
> (below).
> 
> 3/6: s/Never the less/Nevertheless/
> 4/6: s/masquerading/masking/     (masquerade means to "mask oneself")
[...]
> >  	 if git apply --stat --summary broken 2>detected
> >  	 then
> >  		echo unhappy - should have detected an error
> I think this can be changed to:
>    test_must_fail git apply --stat --summary broken 2>detected

  Thank you for your sharp feedback. I will implement the requested
changes for the re-roll.

  Alexander