[PATCH 7/9] vcs-svn: suppress a signed/unsigned comparison warning
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 6, 2012, 17:22 UTC
- Message-ID
- <20120706172254.GH31001@burratino>
- In-Reply-To
- <20120706171040.GA31001@burratino>
From: David Barr <davidbarr@google.com> Date: Fri, 1 Jun 2012 00:41:29 +1000
The preceding code checks that view->max_off is nonnegative and (off + width) fits in an off_t, so this code is already safe.
Signed-off-by: David Barr <davidbarr@google.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Another unobjectionable piece from v2's patch 5. The new change description explains why it's unobjectionable to save future readers some time.
vcs-svn/sliding_window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vcs-svn/sliding_window.c b/vcs-svn/sliding_window.c index ec2707c9..f11d4909 100644 --- a/vcs-svn/sliding_window.c +++ b/vcs-svn/sliding_window.c @@ -54,7 +54,7 @@ int move_window(struct sliding_view *view, off_t off, size_t width) return -1; if (off < view->off || off + width < view->off + view->width) return error("invalid delta: window slides left"); - if (view->max_off >= 0 && view->max_off < off + width) + if (view->max_off >= 0 && view->max_off < off + (off_t) width) return error("delta preimage ends early"); file_offset = view->off + view->buf.len;
-- 1.7.10.4