Re: Apostrophe at the end of author name

From: Kacper Kornet <draenog@pld-linux.org>
Date: Jun 29, 2012, 18:17 UTC
Message-ID: <20120629181701.GB6533@camk.edu.pl>
In-Reply-To: <20120629174358.GB3804@sigill.intra.peff.net>

On Fri, Jun 29, 2012 at 01:43:58PM -0400, Jeff King wrote:

> On Fri, Jun 29, 2012 at 05:05:31PM +0000, Robin H. Johnson wrote:

Show 5 quoted lines

> > On Fri, Jun 29, 2012 at 02:41:22PM +0200,  Kacper Kornet wrote:
> > > I try to import some repositories into git and one of the developers has
> > > asked his name to be presented as: Name 'Nick' <email>.
> > > However git commit --author="Name 'Nick' <email>" strips the last
> > > apostrophe and produces a commit authored by: Name 'Nick <email>.

Show 5 quoted lines

> > > Maybe the function  strbuf_addstr_without_crud in ident.c should strip
> > > the trailing apostrophe only when it removed it also from the beginning
> > > of the string?
> > Which version of Git? And is it being stripped by git, or one of the
> > import tools?

> I'm sure it's the most recent one,

Yes, it is 1.7.11

>  as strbuf_addstr_without_crud was
> only added recently (but it is a refactoring of older code which should
> have the same behavior).

It depends what you call recently. It was refactored in July 2005 (commit: 6aa33f4035d5). But it looks like the previous code (before refactoring) removed only comma, dot and semicolon from the end of the author name.

-- 
  Kacper