Re: Apostrophe at the end of author name

From: Jeff King <peff@peff.net>
Date: Jun 29, 2012, 17:43 UTC
Message-ID: <20120629174358.GB3804@sigill.intra.peff.net>
In-Reply-To: <robbat2-20120629T170457-788694600Z@orbis-terrarum.net>

On Fri, Jun 29, 2012 at 05:05:31PM +0000, Robin H. Johnson wrote:

Show 11 quoted lines

> On Fri, Jun 29, 2012 at 02:41:22PM +0200,  Kacper Kornet wrote:
> > I try to import some repositories into git and one of the developers has
> > asked his name to be presented as: Name 'Nick' <email>.
> > However git commit --author="Name 'Nick' <email>" strips the last
> > apostrophe and produces a commit authored by: Name 'Nick <email>.
> > 
> > Maybe the function  strbuf_addstr_without_crud in ident.c should strip
> > the trailing apostrophe only when it removed it also from the beginning
> > of the string?
> Which version of Git? And is it being stripped by git, or one of the
> import tools?

I'm sure it's the most recent one, as strbuf_addstr_without_crud was only added recently (but it is a refactoring of older code which should have the same behavior). We had a similar complaint recently that "A.B.C. <abc@example.com>" has its trailing dot stripped, even though the internal ones are retained.

Those stripping rules date back to very early versions of git to try to clean up cruft from gecos or other unreliable sources. I wonder if we are better off being a bit more liberal.

-Peff