git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Add C_LOCALE_OUTPUT prereq to test cases that require English text matching

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 25, 2012, 11:53 UTC
Message-ID
<20120625115317.GC9270@burratino>
In-Reply-To
<CACsJy8BMizkU+P6VPhkbY_q2tYY5=aY-GNHeDjBYN9-zg2nENQ@mail.gmail.com>
Nguyen Thai Ngoc Duy wrote:
> What if we allow to run the test suite in non-C locales and skip the
> tests that require C_LOCALE_OUTPUT? In non-C locales, we won't set
> C_LOCALE_OUTPUT prerequisite. This allows to test a localized git with
> ~90% of the test suite. Would it work?

Yes, of course, modulo bugs. :) I guess one thing to watch out for would be assumptions about non-git utilities in the test suite --- for example, some commands such as "sed" have a different idea of what a character is in other locales. But the main ingredient needed is just UI (a test option or envvar).

Previous: Nguyen Thai Ngoc DuyNext: Jonathan Nieder
Message 7 of 11 in “i18n: leave \n out of translated diffstat”
  1. 1/2 i18n: leave \n out of translated diffstatNguyễn Thái Ngọc Duy, Jun 24, 2012
  2. 2/2 Add C_LOCALE_OUTPUT prereq to test cases that require English text matchingNguyễn Thái Ngọc Duy, Jun 24, 2012
  3. Jonathan NiederJun 24, 2012
  4. Nguyen Thai Ngoc DuyJun 25, 2012
  5. Jonathan NiederJun 25, 2012
  6. Nguyen Thai Ngoc DuyJun 25, 2012
  7. Jonathan NiederJun 25, 2012
  8. Jonathan NiederJun 24, 2012
  9. Junio C HamanoJun 25, 2012
  10. Nguyen Thai Ngoc DuyJun 25, 2012
  11. Jonathan NiederJun 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.