From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 25 Jun 2012 11:53:17 GMT
Subject: Re: [PATCH 2/2] Add C_LOCALE_OUTPUT prereq to test cases that require English text matching
Message-ID: <20120625115317.GC9270@burratino>
In-Reply-To: <CACsJy8BMizkU+P6VPhkbY_q2tYY5=aY-GNHeDjBYN9-zg2nENQ@mail.gmail.com>

Nguyen Thai Ngoc Duy wrote:

> What if we allow to run the test suite in non-C locales and skip the
> tests that require C_LOCALE_OUTPUT? In non-C locales, we won't set
> C_LOCALE_OUTPUT prerequisite. This allows to test a localized git with
> ~90% of the test suite. Would it work?

Yes, of course, modulo bugs. :)  I guess one thing to watch out for
would be assumptions about non-git utilities in the test suite --- for
example, some commands such as "sed" have a different idea of what a
character is in other locales.  But the main ingredient needed is just
UI (a test option or envvar).