git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git: Wrong parsing of ssh urls with IPv6 literals ignores port

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 13, 2012, 20:39 UTC
Message-ID
<20120613203959.GD7967@burratino>
In-Reply-To
<7vbokngehi.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> By the way, it seems that Debian/Ubuntu are still carrying a bit
> more changes and rewrites in the connection code as local
> patches. Mind upstreaming them for the next cycle?

Sure --- based on Erik's advice I think the right thing to do is to make a simple compatibility wrapper that acts like normal getaddrinfo, so no one has to learn a new API. It's a little more expensive (some malloc() / free() noise) but probably not enough so to be noticeable.

Debian has these patches because the SRV patch is on top of them.
Previous: Junio C Hamano
Message 9 of 9 in “Re: git: Wrong parsing of ssh urls with IPv6 literals ignores port”
  1. Jonathan NiederJun 10, 2012
  2. René ScharfeJun 12, 2012
  3. Jonathan NiederJun 12, 2012
  4. Jonathan NiederJun 12, 2012
  5. René ScharfeJun 13, 2012
  6. Junio C HamanoJun 13, 2012
  7. Jonathan NiederJun 13, 2012
  8. Junio C HamanoJun 13, 2012
  9. Jonathan NiederJun 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.