Re: git: Wrong parsing of ssh urls with IPv6 literals ignores port
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 13, 2012, 19:43 UTC
- Message-ID
- <20120613194347.GA7967@burratino>
- In-Reply-To
- <7v4nqfi0vz.fsf@alter.siamese.dyndns.org>
On Wed, Jun 13, 2012 at 10:21:04AM -0700, Junio C Hamano wrote:
> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes: >> Am 12.06.2012 23:00, schrieb Jonathan Nieder:
>>> Oh, hold on a second. Won't this get confused by >>> >>> ssh://[::1]/foo/bar/baz:80/qux
[...]
>> It shouldn't, because the host part is NUL-terminated before >> get_port() is called. Let's see (with the patch):
[...]
> Yeah, I was wondering how that would get confused myself. Jonathan, > ack again?
Yeah. I had missed that when proto == PROTO_SSH that means the proto != PROTO_LOCAL branch has been taken and the port is NUL-terminated.
So
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
It seems like a good fix given the current code structure. Sorry for the false alarm.