Re: [PATCH] pager: drop "wait for output to run less" hack

From: Jeff King <peff@peff.net>
Date: Jun 5, 2012, 16:01 UTC
Message-ID: <20120605160157.GA20582@sigill.intra.peff.net>
In-Reply-To: <CABPQNSbhgan+i_Q142R8VvRdJ5T+GyYHqgEJ6KS-BBJguRu-OQ@mail.gmail.com>

On Tue, Jun 05, 2012 at 05:52:24PM +0200, Erik Faye-Lund wrote:

Show 10 quoted lines

> On Tue, Jun 5, 2012 at 10:56 AM, Jeff King <peff@peff.net> wrote:
> > I checked, and even RHEL5 is on less 436. So besides people on antique
> > "I installed less from source more than 5 years ago" systems, my only
> > concern would be that some other pager depends on this hack in a weird
> > way. But I have never heard of such a thing, so...
> 
> On my RHEL5 box at work:
> $ less --version
> less 394
> Copyright (C) 1984-2005 Mark Nudelman

Then I think you are not following the bug-fix updates, as they've issued several updates based on 436:

  https://rhn.redhat.com/errata/RHBA-2010-0214.html

  https://rhn.redhat.com/errata/RHBA-2010-0805.html

  http://rhn.redhat.com/errata/RHBA-2011-1468.html

Looks like 394 was shipping as recently as 2009:

  https://rhn.redhat.com/errata/RHBA-2009-0413.html

Given that the buggy less is apparently still in the wild, and that the patch is a pure cleanup, I guess we should scrap it for now. <sigh>

-Peff