Re: [PATCH] pager: drop "wait for output to run less" hack

From: Jeff King <peff@peff.net>
Date: Jun 5, 2012, 15:50 UTC
Message-ID: <20120605155007.GA20494@sigill.intra.peff.net>
In-Reply-To: <7vwr3lpxyh.fsf@alter.siamese.dyndns.org>

On Tue, Jun 05, 2012 at 08:42:14AM -0700, Junio C Hamano wrote:

> > I'm really tempted to do this:
> 
> Why (I am slower than my usual slow self today, so pardon me)?

Purely to clean up the nasty preexec thing, which is a hack, and should never be used for new code due to portability issues.

> Aren't these already protected with "ifndef WIN32"?

Yes, but it means anything that uses it will not work on Windows.

Show 6 quoted lines

> > I checked, and even RHEL5 is on less 436. So besides people on antique
> > "I installed less from source more than 5 years ago" systems, my only
> > concern would be that some other pager depends on this hack in a weird
> > way. But I have never heard of such a thing, so...
> 
> Hrm...

Yeah. This is purely a cleanup thing. It's a cleanup I've wanted to do for a long time (ever since adding it), but it is not hurting anyone as-is. We can always just reject new uses of preexec_cb in review (which is more or less what I'm doing here).

-Peff