Re: [PATCH] Add persistent-https to contrib
- From
Jeff King <peff@peff.net>
- Date
- May 24, 2012, 20:29 UTC
- Message-ID
- <20120524202930.GB18936@sigill.intra.peff.net>
- In-Reply-To
- <CAJo=hJt=q-ZnLrqzcfGrKNcao2MPDSRt3Y_r2OOfu75++N+3zw@mail.gmail.com>
On Thu, May 24, 2012 at 12:33:08PM -0700, Shawn O. Pearce wrote:
Show 8 quoted lines
> $ (for i in {1..5}; do time git ls-remote
> persistent-https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux
> >/dev/null;done) 2>&1 | grep real
> real 0m0.208s
> real 0m0.085s
> real 0m0.079s
> real 0m0.067s
> real 0m0.059sNice numbers. And as clever as I find this helper-wrapping-a-helper solution, I wonder if the right layer for a fix isn't inside curl. It already keeps an ssl session-id cache in memory; how hard would it be to turn that into an on-disk cache?
I don't think that is grounds for rejecting this patch; obviously it is working for you guys, and it is available right now, and it is only going into contrib/ anyway. But a curl solution seems like a cleaner long-term fix, and would benefit all curl users. It is even mentioned in curl's doc/TODO file. :)
-Peff