git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: contrib/credential/osxkeychain: Makefile should allow to set CFLAGS

From
Jeff King <peff@peff.net>
Date
May 24, 2012, 17:51 UTC
Message-ID
<20120524175143.GD3161@sigill.intra.peff.net>
In-Reply-To
<7vaa0xxz14.fsf@alter.siamese.dyndns.org>
On Thu, May 24, 2012 at 10:35:35AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> > I think so. Why don't we do this?
> 
> I am OK with that.
> 
> CFLAGS/LDFLAGS that come from ../../../config.mak _might_ not be suitable
> for this binary, but I do not think of a concrete example how that could
> be.  Besides, this is just an example in contrib/ so I'd not worry about
> it too much.

Yeah, I considered that, but I figured that what you have in config.mak is _at least_ as sensible as the random defaults I stuck in the Makefile. And overriding with "make CFLAGS=..." is still available.

-Peff
Previous: Junio C Hamano
Message 5 of 5 in “contrib/credential/osxkeychain: Makefile should allow to set CFLAGS”
  1. Samuel JohnMay 22, 2012
  2. Junio C HamanoMay 22, 2012
  3. Jeff KingMay 23, 2012
  4. Junio C HamanoMay 24, 2012
  5. Jeff KingMay 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.