From: Jeff King <peff@peff.net>
Date: Thu, 24 May 2012 17:51:43 GMT
Subject: Re: contrib/credential/osxkeychain: Makefile should allow to set CFLAGS
Message-ID: <20120524175143.GD3161@sigill.intra.peff.net>
In-Reply-To: <7vaa0xxz14.fsf@alter.siamese.dyndns.org>

On Thu, May 24, 2012 at 10:35:35AM -0700, Junio C Hamano wrote:

> > I think so. Why don't we do this?
> 
> I am OK with that.
> 
> CFLAGS/LDFLAGS that come from ../../../config.mak _might_ not be suitable
> for this binary, but I do not think of a concrete example how that could
> be.  Besides, this is just an example in contrib/ so I'd not worry about
> it too much.

Yeah, I considered that, but I figured that what you have in config.mak
is _at least_ as sensible as the random defaults I stuck in the
Makefile.  And overriding with "make CFLAGS=..." is still available.

-Peff