Re: [PATCH 05/13] move git_default_* variables to ident.c

From: Jeff King <peff@peff.net>
Date: May 21, 2012, 05:41 UTC
Message-ID: <20120521054118.GA2077@sigill.intra.peff.net>
In-Reply-To: <7vsjeu89dd.fsf@alter.siamese.dyndns.org>

On Sun, May 20, 2012 at 09:07:42PM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > diff --git a/cache.h b/cache.h
> > index 86224c8..f63b71f 100644
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -1142,9 +1142,6 @@ struct config_include_data {
> >  #define CONFIG_INCLUDE_INIT { 0 }
> >  extern int git_config_include(const char *name, const char *value, void *data);
> >  
> > -#define MAX_GITNAME (1000)
> > -extern char git_default_email[MAX_GITNAME];
> > -extern char git_default_name[MAX_GITNAME];
> >  #define IDENT_NAME_GIVEN 01
> >  #define IDENT_MAIL_GIVEN 02
> >  #define IDENT_ALL_GIVEN (IDENT_NAME_GIVEN|IDENT_MAIL_GIVEN)
> 
> During this step, builtin/fmt-merge-msg.c ceases to compile, even though
> in the end it is fixed...

Hrm. I ran the series through "make" on each commit before submitting, and it compiled fine. I just did it again to double-check, and it's still fine.

What was the error you got? Are you sure you had 03/13 in place beforehand, which removes the use of MAX_GITNAME from builtin/fmt-merge-msg.c?

-Peff