[PATCH 02/13] http-push: do not access git_default_email directly
- From
Jeff King <peff@peff.net>
- Date
- May 18, 2012, 23:09 UTC
- Message-ID
- <20120518230905.GB30031@sigill.intra.peff.net>
- In-Reply-To
- <20120518230528.GA30510@sigill.intra.peff.net>
By calling the ident_default_email accessor, we can be sure that the default value is actually filled-in.
Signed-off-by: Jeff King <peff@peff.net> --- I believe this is a real, triggerable bug if you don't have your user.email config set, but I didn't actually test it (and I have no idea if DAV would actually care about an empty email here anyway).
http-push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http-push.c b/http-push.c index 1df7ab5..a832ca7 100644 --- a/http-push.c +++ b/http-push.c @@ -904,7 +904,7 @@ static struct remote_lock *lock_remote(const char *path, long timeout) ep = strchr(ep + 1, '/'); } - escaped = xml_entities(git_default_email); + escaped = xml_entities(ident_default_email()); strbuf_addf(&out_buffer.buf, LOCK_REQUEST, escaped); free(escaped);
-- 1.7.10.1.16.g53a707b