git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3404: begin "exchange commits with -p" test with correct preconditions

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 19, 2012, 22:15 UTC
Message-ID
<20120519221543.GE4567@burratino>
In-Reply-To
<4FB79CA8.7080103@kdbg.org>
Johannes Sixt wrote:
Show 8 quoted lines
> The test case shows a bug in 'rebase -p', but even if the bug were fixed
> the test would fail because it did not ensure that the preconditions match
> the postconditions that were checked. Insert the suitable 'git checkout'.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  Could it be that this bug existed since the test case was introduced
>  in cddb42d2?

Yeah, looks like it was always broken. I remember sanity checking by removing the "-p", too, but that was probably before moving the test to join the other -p tests. Thanks for fixing it.

Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Johannes Sixt
Message 2 of 2 in “t3404: begin "exchange commits with -p" test with correct preconditions”
  1. t3404: begin "exchange commits with -p" test with correct preconditionsJohannes Sixt, May 19, 2012
  2. Jonathan NiederMay 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.