From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sat, 19 May 2012 22:15:43 GMT
Subject: Re: [PATCH] t3404: begin "exchange commits with -p" test with correct preconditions
Message-ID: <20120519221543.GE4567@burratino>
In-Reply-To: <4FB79CA8.7080103@kdbg.org>

Johannes Sixt wrote:

> The test case shows a bug in 'rebase -p', but even if the bug were fixed
> the test would fail because it did not ensure that the preconditions match
> the postconditions that were checked. Insert the suitable 'git checkout'.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  Could it be that this bug existed since the test case was introduced
>  in cddb42d2?

Yeah, looks like it was always broken.  I remember sanity checking
by removing the "-p", too, but that was probably before moving the
test to join the other -p tests.  Thanks for fixing it.

Acked-by: Jonathan Nieder <jrnieder@gmail.com>