git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Jonathan gives feedback --> flamewars inevitable?

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 5, 2012, 18:39 UTC
Message-ID
<20120505183954.GA18844@burratino>
In-Reply-To
<CAMP44s1SLb6CXMKxRDFUbxkg56dU3=ObZPZh7XxQC3vovNnvdw@mail.gmail.com>
Felipe Contreras wrote:
> If you had said "You know, I think they have this guideline, but it's
> not really relevant, what is relevant is X" right when the topic of
> bash-completion guidelines popped up, this thread would have looked
> much different.
Ah, apparently I was still unclear.

The leading underscore is a convention. They do use it. They are thinking of moving to another convention and will probably do so.

I believe that convention is relevant to the git completion script. Not because we should blindly follow everything the bash-completion project does, but because there are reasons behind that convention, following common practices means our behavior is less surprising, and in fact I do want it to be possible to incorporate git's completion script in the bash-completion project if that's convenient.

A little changed because their proposed future namespace does not make it possible for outside contributors to make unofficial extensions and then include them as something official later without change. Maybe that's a flaw.

When I stated what I thought was (and still think is) a fact, and you decided that the best use of your time was to argue with me about that instead of talking about the consequences, yes, I was annoyed. It was a rabbit hole I shouldn't have followed; you're right. But I still don't know what I should have said instead, or how to stop it from coming up again and again.

Jonathan
Previous: Felipe ContrerasNext: Jonathan Nieder
Message 9 of 24 in “completion: add new _GIT_complete helper”
  1. completion: add new _GIT_complete helperFelipe Contreras, May 5, 2012
  2. Jonathan NiederMay 5, 2012
  3. Felipe ContrerasMay 5, 2012
  4. Jonathan NiederMay 5, 2012
  5. Jonathan NiederMay 5, 2012
  6. Felipe ContrerasMay 5, 2012
  7. Jonathan gives feedback --> flamewars inevitable? (Re: [PATCH v3] completion: add new _GIT_complete helper)Jonathan Nieder, May 5, 2012
  8. Felipe ContrerasMay 5, 2012
  9. Jonathan NiederMay 5, 2012
  10. Jonathan NiederMay 5, 2012
  11. Tay Ray ChuanMay 6, 2012
  12. Felipe ContrerasMay 14, 2012
  13. Jonathan NiederMay 5, 2012
  14. SZEDER GáborMay 6, 2012
  15. Jonathan NiederMay 6, 2012
  16. SZEDER GáborMay 6, 2012
  17. SZEDER GáborMay 6, 2012
  18. SZEDER GáborMay 6, 2012
  19. SZEDER GáborMay 6, 2012
  20. Felipe ContrerasMay 6, 2012
  21. Felipe ContrerasMay 6, 2012
  22. SZEDER GáborMay 6, 2012
  23. Felipe ContrerasMay 7, 2012
  24. SZEDER GáborMay 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.