Re: [PATCH 5/6] http: Avoid limit of retrying request only twice
- From
Jeff King <peff@peff.net>
- Date
- May 4, 2012, 09:28 UTC
- Message-ID
- <20120504092814.GA24398@sigill.intra.peff.net>
- In-Reply-To
- <4FA3AD72.1010407@seap.minhap.es>
On Fri, May 04, 2012 at 12:20:34PM +0200, Nelson Benitez Leon wrote:
Show 22 quoted lines
> On 05/04/2012 09:24 AM, Jeff King wrote: > > On Thu, May 03, 2012 at 06:40:28PM +0200, Nelson Benitez Leon wrote: > > > >> [snip] > >> > >> Now we retry as long as we keep receiving HTTP_REAUTH, so the previous > >> sequence correctly completes. > >> > >> Patch by Jeff King <peff@peff.net> > > > > We usually spell that as: > > > > From: Jeff King <peff@peff.net> > > > > at the beginning of the email body (which lets am set the author > > appropriately). > > Are you saying the first line of the email body? isn't that for the > commit message first-line? I suppose you're not refering to the 'from > field' of the email as I would need alter identities in my email client > and found that cumbersome. Sorry for me not getting it and asking for > clarification.
Yes, that's what I am saying. When Junio applies the patch using "git am", git will recognize these extra "pseudo-headers" at the top of the body, remove them from the commit message, and override the email headers with them.
It does this for exactly this case; you can leave your email headers intact, but still provide attribution to someone else.
-Peff