git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] http: Avoid limit of retrying request only twice

From
Jeff King <peff@peff.net>
Date
May 4, 2012, 07:24 UTC
Message-ID
<20120504072427.GE21895@sigill.intra.peff.net>
In-Reply-To
<4FA2B4FC.3030309@seap.minhap.es>
On Thu, May 03, 2012 at 06:40:28PM +0200, Nelson Benitez Leon wrote:
Show 16 quoted lines
> Current code, after receiving HTTP_REAUTH, only retried
> once, so couldn't do step 3 of the following sequence:
> 
>   1. We make a request; proxy returns 407, because we didn't give it a
>      password. We ask for the password and return HTTP_REAUTH.
> 
>   2. We make another request; the proxy passes it to the actual server,
>      who returns 401, because we didn't give an http password. We ask
>      for the password and return HTTP_REAUTH.
> 
>   3. We make a third request, but this time everybody is happy.
> 
> Now we retry as long as we keep receiving HTTP_REAUTH, so the previous
> sequence correctly completes.
> 
> Patch by Jeff King <peff@peff.net>
We usually spell that as:
  From: Jeff King <peff@peff.net>

at the beginning of the email body (which lets am set the author appropriately).

Other than that, the patch looks good to me (unsurprisingly :) ).
-Peff
Previous: Nelson Benitez LeonNext: Nelson Benitez Leon
Message 2 of 4 in “http: Avoid limit of retrying request only twice”
  1. 5/6 http: Avoid limit of retrying request only twiceNelson Benitez Leon, May 3, 2012
  2. Jeff KingMay 4, 2012
  3. Nelson Benitez LeonMay 4, 2012
  4. Jeff KingMay 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.