git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 0/4] git p4: label import/export

From
PWPete Wyckoff <pw@padd.com>
Date
Apr 25, 2012, 22:22 UTC
Message-ID
<20120425222205.GA1753@padd.com>
In-Reply-To
<1335254897-15242-1-git-send-email-luke@diamand.org>
luke@diamand.org wrote on Tue, 24 Apr 2012 09:08 +0100:
Show 7 quoted lines
> This is a reworked version of my earlier patches for adding
> improved label import/export support to "git p4", and
> incorporates comments from Pete Wyckoff and Junio:
> 
> Comments from Pete:
> 
> * The verbose flag has been hoisted to the Command class.
Thanks, this looks great.
Show 6 quoted lines
> * Uses the existing functions to fish out p4 changelist numbers.
> * Config options renamed to be self-consistent, and regexp
>   now includes lower-case characters.
> 
> I have left the tests in t9811 where they are, so that the t9804
> script can be used solely for "--detect-labels".

Oh, okay. 9804 is about --detect-labels, which still has the two-labels-on-same-changelist problem. 9811 is the new stuff, and the similar test there works.

Anyway, ack your v4 that is this plus your doc fix.  Thanks,
		-- Pete
Show 11 quoted lines
> Comments from Junio:
> 
> * P4EDITOR is set to the always-true value in the test harness
> * Treat an empty P4EDITOR the same as an unset P4EDITOR.
> 
> There was a discussion about having "git p4" fall back to a default in
> the same way that "p4" does, but this would change the existing behavior
> (use git var GIT_EDITOR) and confuse users.
> 
> This patch series was reworked against ld/git-p4-tags-and-labels and
> also has a very small documentation fix.
Previous: Luke Diamand
Message 7 of 7 in “[PATCHv3 0/4] git p4: label import/export”
  1. Luke DiamandApr 24, 2012
  2. 1/5 git p4: Fixing script editor checksLuke Diamand, Apr 24, 2012
  3. 2/5 git p4: Squash P4EDITOR in test harnessLuke Diamand, Apr 24, 2012
  4. 3/5 git p4: Ignore P4EDITOR if it is emptyLuke Diamand, Apr 24, 2012
  5. 4/5 git p4: import/export of labels to/from p4Luke Diamand, Apr 24, 2012
  6. 5/5 git p4: move verbose to base classLuke Diamand, Apr 24, 2012
  7. Pete WyckoffApr 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.