git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 1/5] git p4: Fixing script editor checks

From
Luke Diamand <luke@diamand.org>
Date
Apr 24, 2012, 08:08 UTC
Message-ID
<1335254897-15242-2-git-send-email-luke@diamand.org>
In-Reply-To
<1335254897-15242-1-git-send-email-luke@diamand.org>

If P4EDITOR is defined, the tests will fail when "git p4" starts an editor.

Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t9800-git-p4-basic.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 13be144..b2f0869 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -335,7 +335,7 @@ test_expect_success 'detect renames' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		git config git-p4.skipSubmitEditCheck true &&
+		git config git-p4.skipSubmitEdit true &&
 
 		git mv file1 file4 &&
 		git commit -a -m "Rename file1 to file4" &&
@@ -394,7 +394,7 @@ test_expect_success 'detect copies' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		git config git-p4.skipSubmitEditCheck true &&
+		git config git-p4.skipSubmitEdit true &&
 
 		cp file2 file8 &&
 		git add file8 &&
-- 
1.7.10.381.gb484f
Previous: Luke DiamandNext: Luke Diamand
Message 2 of 7 in “[PATCHv3 0/4] git p4: label import/export”
  1. Luke DiamandApr 24, 2012
  2. 1/5 git p4: Fixing script editor checksLuke Diamand, Apr 24, 2012
  3. 2/5 git p4: Squash P4EDITOR in test harnessLuke Diamand, Apr 24, 2012
  4. 3/5 git p4: Ignore P4EDITOR if it is emptyLuke Diamand, Apr 24, 2012
  5. 4/5 git p4: import/export of labels to/from p4Luke Diamand, Apr 24, 2012
  6. 5/5 git p4: move verbose to base classLuke Diamand, Apr 24, 2012
  7. Pete WyckoffApr 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.