Re: [PATCH] Fixed compilation with Visual Studio by including poll.h

From: Jeff King <peff@peff.net>
Date: Apr 20, 2012, 20:47 UTC
Message-ID: <20120420204722.GD13103@sigill.intra.peff.net>
In-Reply-To: <4F91C8FF.7070402@tu-clausthal.de>

On Fri, Apr 20, 2012 at 10:37:19PM +0200, Sven Strickroth wrote:

> upload-archive.c and upload-pack.c use pollfd struct and POLLIN constant
> which are defined in poll.h. However, poll.h is not included.

This should already be included by git-compat-util.h:

  $ grep -C1 poll.h git-compat-util.h
  #ifndef NO_SYS_POLL_H
  #include <sys/poll.h>
  #else
  #include <poll.h>
  #endif

It looks like we will prefer sys/poll.h if it exists. The official XSI location is "poll.h", but I guess in practice they are equivalent on most systems if you have both (certainly on Linux, poll.h just includes sys/poll.h).

Does your environments have a sys/poll.h that exists isn't sufficient to use poll? Maybe we need to tweak git-compat-util to include both if they both exist.

-Peff