[PATCH v2 0/2] Re: fast-import: fix ls command with empty path

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 8, 2012, 20:27 UTC
Message-ID: <20120308202721.GA8992@burratino>
In-Reply-To: <1331184656-98629-1-git-send-email-davidbarr@google.com>

David Barr wrote:

Show 14 quoted lines

> When the following command is sent to fast-import:
>
>  'ls' SP ':1' SP LF
>
> The expected output is:
>
>  '040000' SP 'tree' SP <dataref> HT LF
>
> The actual output is:
>
>  'missing' SP LF
>
> This is because tree_content_get() is called but expects a non-empty
> path. Instead, copy the root entry and force the mode to S_IFDIR.

Thanks again for your help.  I've pushed the following changes to

  git://repo.or.cz/git/jrn.git fast-import-pu

Testing, review, and improvements welcome.

David Barr (1):
  fast-import: teach ls command to accept empty path

Jonathan Nieder (1):
  fast-import: plug leak of dirty trees in 'ls' command

 fast-import.c          |   19 +++++++++-
 t/t9300-fast-import.sh |   95 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+), 1 deletion(-)