Re: [PATCH] fast-import: fix ls command with empty path

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 8, 2012, 19:32 UTC
Message-ID: <20120308193220.GA27916@burratino>
In-Reply-To: <CA+gfSn8bh-tV+uduM7xsuwqXQW2a57yvVmRXjXjp9JaO779bUg@mail.gmail.com>

Dmitry Ivankov wrote:

>  One more quick thought. "force the root mode to S_IFDIR" part doesn't
>  look obviously good for me.

It was just a problematic and incomplete version of what your "be saner with temporary trees" does properly. ;-)

[...]

>  P.S. looking at [1] now I'd say the commit messages could be improved there
>
>  [1] http://thread.gmane.org/gmane.comp.version-control.git/179426

Yes, please. Or patch 2/2 could be split into multiple patches, perhaps along the following lines:

 - ls "" support, as in David's patch
 - ls <dataref> "" support, which requires the "be saner with
   temporaries" fix
 - D "" support, maybe.  (As you mentioned, we have deleteall so
   compatibility would dictate not supporting it unless some frontend
   is using it already by mistake in some circumstance.)
 - C "" <dest> support, as in my reply to David's patch
 - R "" <dest> support

Thanks, Jonathan