Re: [PATCH 2/2] do not stream large files to pack when filters are in use

From: Jeff King <peff@peff.net>
Date: Feb 24, 2012, 21:19 UTC
Message-ID: <20120224211913.GA30942@sigill.intra.peff.net>
In-Reply-To: <20120224204810.GC21447@sigill.intra.peff.net>

On Fri, Feb 24, 2012 at 03:48:10PM -0500, Jeff King wrote:

Show 6 quoted lines

> > By the way, I tried this with the tip of 'pu' as of last night, and the
> > result segfaults on me in t1050 (hash-object -w) ;-).
> 
> Eek. I ran through "make test" on my finished series without a problem,
> but it may be a bad interaction with something in "pu", or maybe a
> heisenbug. I'll investigate.

Or maybe I'm just an idiot, and apparently didn't actually run the test suite correctly. Because it is very reproducible, and is because hash-object --stdin passes a NULL for the path.

I'll post the fixed series in a minute (with this fix, and the improved convert_to_git wrapper).

-Peff