Re: General support for ! in git-config values
- From
Jeff King <peff@peff.net>
- Date
- Feb 2, 2012, 09:54 UTC
- Message-ID
- <20120202095432.GA19356@sigill.intra.peff.net>
- In-Reply-To
- <CANgJU+X2dRP__PFAywGEisDS3xyF7fSszSQG6BO61j2TMKL3Qg@mail.gmail.com>
On Thu, Feb 02, 2012 at 10:44:05AM +0100, demerphq wrote:
Show 6 quoted lines
> The general design of git seems to me to be based around providing > building blocks that people can use to build new and interesting tools > on top of, and so it seems counter to that philosophy to reject an > feature based on speculative security issues that really can't be > decided in advance but must instead be decided on a case by case > basis.
I can't speak for Junio, but I am certainly not rejecting it. Only saying that it needs to be thought through, and the utility weighed against the costs. So far I haven't seen an actual patch to comment on (or even a proposed syntax beyond starting a string with "!", which I think is a non-starter due to conflicting with existing uses), nor have I seen a concrete use case (you mentioned pulling the name/email from ldap, but you also mentioned that there are lots of other ways of solving that particular problem, so it's not especially compelling).
I'd be happy to hear a more concrete proposal.
-Peff