Re: [PATCH v4 1/2] gitweb: add project_filter to limit project list to a subdirectory

From: Bernhard R. Link <brl+git@mail.brlink.eu>
Date: Jan 30, 2012, 09:52 UTC
Message-ID: <20120130095252.GA6183@server.brlink.eu>
In-Reply-To: <7v7h0afcc2.fsf@alter.siamese.dyndns.org>

* Junio C Hamano <gitster@pobox.com> [120129 22:06]:

Show 12 quoted lines

> > @@ -2864,6 +2873,10 @@ sub git_get_projects_list {
> >  				}
> >  
> >  				my $path = substr($File::Find::name, $pfxlen + 1);
> > +				# paranoidly only filter here
> > +				if ($paranoid && $filter && $path !~ m!^\Q$filter\E/!) {
> > +					next;
> > +				}
>
> When you find "foo" directory and a project_filter tells you to match
> "foo", because $path does not match "^foo/", it will not match (even
> though its subdirectory "foo/bar" would)?

Yes, for consistency with what would be shown with a project list file. (And that it would only show projects which would have a link to this directory in their breadcrumbs (with 2/2)).

> Perhaps that is the topic of your second patch. I dunno.

Yes, that is what the second patch does.

        Bernhard R. Link