Re: [PATCH v4 2/2] gitweb: place links to parent directories in page header
On Sun, 29 Jan 2012, Bernhard R. Link wrote:
> Change html page headers to not only link the project root and the
> currently selected project but also the directories in between using
> project_filter.
Nice interface to the new feature... though it doesn't really address
the problem that gitweb homepage is slow to generate with large number
of projects. Still, it is IMVHO a good improvement.
> Signed-off-by: Bernhard R. Link <brlink@debian.org>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Show 21 quoted lines
> ---
> gitweb/gitweb.perl | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f0e03d8..e2a9146 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3853,7 +3853,10 @@ sub print_nav_breadcrumbs {
>
> print $cgi->a({-href => esc_url($home_link)}, $home_link_str) . " / ";
> if (defined $project) {
> - print $cgi->a({-href => href(action=>"summary")}, esc_html($project));
> + my @dirname = split '/', $project;
> + my $projectbasename = pop @dirname;
> + print_nav_breadcrumbs_path(@dirname);
> + print $cgi->a({-href => href(action=>"summary")}, esc_html($projectbasename));
> if (defined $action) {
> my $action_print = $action ;
> if (defined $opts{-action_extra}) {
> -- Nicely short with refactoring of print_nav_breadcrumbs_path() in 1/2!
--
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>