git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 0/5] git-p4: small fixes to branches and labels

From
PWPete Wyckoff <pw@padd.com>
Date
Jan 19, 2012, 15:19 UTC
Message-ID
<20120119151934.GA3698@padd.com>
In-Reply-To
<1326966749-9077-1-git-send-email-luke@diamand.org>
luke@diamand.org wrote on Thu, 19 Jan 2012 09:52 +0000:
Show 9 quoted lines
> This is the fourth version of some small fixes to git-p4 branch and
> label handling, incorporating a fix from Pete Wyckoff and an
> additional failing test.
> 
> This change does not fix the other problems with git-p4 labels:
> 
> - two p4 labels on the same changelist will fall over
> - labels must match exactly the list of files imported
> - you can't import a label without a p4 commit

This all looks great to me. Thanks for adding that failing test, and fixing the pre-existing bug in invoking p4 labels.

		-- Pete
Previous: Luke Diamand
Message 7 of 7 in “[PATCHv4 0/5] git-p4: small fixes to branches and labels”
  1. Luke DiamandJan 19, 2012
  2. 1/5 git-p4: handle p4 branches and labels containing shell charsLuke Diamand, Jan 19, 2012
  3. 2/5 git-p4: cope with labels with empty descriptionsLuke Diamand, Jan 19, 2012
  4. 3/5 git-p4: importing labels should cope with missing ownerLuke Diamand, Jan 19, 2012
  5. 4/5 git-p4: add test for p4 labelsLuke Diamand, Jan 19, 2012
  6. 5/5 git-p4: label import fails with multiple labels at the same changelistLuke Diamand, Jan 19, 2012
  7. Pete WyckoffJan 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.