From: Pete Wyckoff Date: Thu, 19 Jan 2012 15:19:34 GMT Subject: Re: [PATCHv4 0/5] git-p4: small fixes to branches and labels Message-ID: <20120119151934.GA3698@padd.com> In-Reply-To: <1326966749-9077-1-git-send-email-luke@diamand.org> luke@diamand.org wrote on Thu, 19 Jan 2012 09:52 +0000: > This is the fourth version of some small fixes to git-p4 branch and > label handling, incorporating a fix from Pete Wyckoff and an > additional failing test. > > This change does not fix the other problems with git-p4 labels: > > - two p4 labels on the same changelist will fall over > - labels must match exactly the list of files imported > - you can't import a label without a p4 commit This all looks great to me. Thanks for adding that failing test, and fixing the pre-existing bug in invoking p4 labels. -- Pete