git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test_interactive: interactive debugging in test scripts

From
PWPete Wyckoff <pw@padd.com>
Date
Jan 16, 2012, 22:07 UTC
Message-ID
<20120116220712.GA30785@padd.com>
In-Reply-To
<4F148D3B.4070206@web.de>
Jens.Lehmann@web.de wrote on Mon, 16 Jan 2012 21:48 +0100:
Show 14 quoted lines
> Am 16.01.2012 21:11, schrieb Jeff King:
> > On Mon, Jan 16, 2012 at 09:01:21PM +0100, Jens Lehmann wrote:
> > 
> >> So I vote for your patch as it takes my initial idea even further. I
> >> really like that HOME, TERM and SHELL are honored in your version
> >> leaving the user with a fully functional shell of his choice.
> > 
> > I'm actually mildly negative on this feature, as it interferes with the
> > tests themselves. Probably TERM and SHELL don't matter. But $HOME means
> > git will read your personal .gitconfig, not any config (or lack thereof)
> > in the trash directory.
> 
> Good point, I haven't thought of that ... so yes, at least $HOME should
> go.

I, too, have stumbled over differences that are due to picking up something in $HOME. It takes a minute to realize what's going on.

TERM can interfere with at least one test: c2116a1 (test-lib: fix TERM to dumb for test repeatability, 2008-03-06). SHELL can cause issues when it is more feature-ful than SHELL_PATH.

On the other hand, it's frustrating to work in an environment without my shell aliases, git aliases, readline customizations, personal path, and assorted environment variables.

I'm comfortable with the (rare?) possibility of confusion. But perhaps it is unwise to support a feature with so many caveats, even if it is only for debugging.

		-- Pete
Previous: Jens LehmannNext: Jeff King
Message 7 of 12 in “test-lib: add the test_bash convenience function”
  1. test-lib: add the test_bash convenience functionJens Lehmann, Jan 15, 2012
  2. Jeff KingJan 15, 2012
  3. test_interactive: interactive debugging in test scriptsPete Wyckoff, Jan 16, 2012
  4. Jens LehmannJan 16, 2012
  5. Jeff KingJan 16, 2012
  6. Jens LehmannJan 16, 2012
  7. Pete WyckoffJan 16, 2012
  8. Jeff KingJan 16, 2012
  9. Junio C HamanoJan 16, 2012
  10. test-lib: add the test_pause convenience functionJens Lehmann, Jan 17, 2012
  11. Junio C HamanoJan 17, 2012
  12. test-lib: add the test_pause convenience functionJens Lehmann, Jan 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.