Re: [PATCH] test_interactive: interactive debugging in test scripts

From: Jeff King <peff@peff.net>
Date: Jan 16, 2012, 20:11 UTC
Message-ID: <20120116201123.GA18699@sigill.intra.peff.net>
In-Reply-To: <4F148211.70106@web.de>

On Mon, Jan 16, 2012 at 09:01:21PM +0100, Jens Lehmann wrote:

> So I vote for your patch as it takes my initial idea even further. I
> really like that HOME, TERM and SHELL are honored in your version
> leaving the user with a fully functional shell of his choice.

I'm actually mildly negative on this feature, as it interferes with the tests themselves. Probably TERM and SHELL don't matter. But $HOME means git will read your personal .gitconfig, not any config (or lack thereof) in the trash directory.

I've personally been left head-scratching in the past by:

  $ ./tXXXX-foo -v -i
  ...
  expecting success: git foo
  not ok - 1 git foo

  $ cd trash\ directory.tXXXX-foo
  $ git foo ;# and it works!

where the culprit was a non-clean environment caused by my personal git config (or very occasionally, something else in $HOME).

-Peff