Re: [PATCH] Specify a precision for the length of a subject string

From: Jeff King <peff@peff.net>
Date: Dec 23, 2011, 23:03 UTC
Message-ID: <20111223230332.GA1734@sigill.intra.peff.net>
In-Reply-To: <20111223230228.GA1718@sigill.intra.peff.net>

On Fri, Dec 23, 2011 at 06:02:28PM -0500, Jeff King wrote:

Show 15 quoted lines

> On Fri, Dec 23, 2011 at 12:58:00PM -0800, Junio C Hamano wrote:
> 
> > > Here's how I would have done it. Not involving %w at all, but applying
> > > equally to all placeholders.
> > 
> > Hmm, just curious why you rejected the %w() approach, as enhancing %w
> > sounded to me like a better approach at the design level, but that was a
> > knee-jerk reaction without inspecting the codepaths involved myself hence
> > not knowing the potential amount of work required.
> 
> Not so much rejecting as I took a quick look at how I would have done
> what your original patch did, and it was simple enough that I took it
> all the way to working and decided to post it. I left it up to you to
> decide whether using %w would be more sensible. I just wanted to present
> another alternative for discussion.

Eh, I misread the "From" header. All of the "you" there is "Nathan".

-Peff