git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Specify a precision for the length of a subject string

From
Jeff King <peff@peff.net>
Date
Dec 23, 2011, 23:02 UTC
Message-ID
<20111223230228.GA1718@sigill.intra.peff.net>
In-Reply-To
<7v1urvc8fb.fsf@alter.siamese.dyndns.org>
On Fri, Dec 23, 2011 at 12:58:00PM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> > Here's how I would have done it. Not involving %w at all, but applying
> > equally to all placeholders.
> 
> Hmm, just curious why you rejected the %w() approach, as enhancing %w
> sounded to me like a better approach at the design level, but that was a
> knee-jerk reaction without inspecting the codepaths involved myself hence
> not knowing the potential amount of work required.

Not so much rejecting as I took a quick look at how I would have done what your original patch did, and it was simple enough that I took it all the way to working and decided to post it. I left it up to you to decide whether using %w would be more sensible. I just wanted to present another alternative for discussion.

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 9 of 15 in “Specify a precision for the length of a subject string”
  1. Specify a precision for the length of a subject stringNathan W. Panike, Dec 20, 2011
  2. Thomas RastDec 20, 2011
  3. Nathan PanikeDec 20, 2011
  4. Jeff KingDec 21, 2011
  5. Nathan PanikeDec 21, 2011
  6. Jeff KingDec 23, 2011
  7. Jeff KingDec 23, 2011
  8. Junio C HamanoDec 23, 2011
  9. Jeff KingDec 23, 2011
  10. Jeff KingDec 23, 2011
  11. 1/2 pretty: refactor --format "magic" placeholdersJeff King, Dec 23, 2011
  12. 2/2 pretty: allow "max-size" magic for all placeholdersJeff King, Dec 23, 2011
  13. Andreas SchwabDec 21, 2011
  14. Nathan PanikeDec 21, 2011
  15. Miles BaderDec 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.