git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] mv: honor --verbose flag

From
Jeff King <peff@peff.net>
Date
Dec 12, 2011, 21:45 UTC
Message-ID
<20111212214516.GC9754@sigill.intra.peff.net>
In-Reply-To
<7vwra136tj.fsf@alter.siamese.dyndns.org>
On Mon, Dec 12, 2011 at 11:53:28AM -0800, Junio C Hamano wrote:
Show 14 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > The code for a verbose flag has been here since "git mv" was
> > converted to C many years ago, but actually getting the "-v"
> > flag from the command line was accidentally lost in the
> > transition.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > This has been broken since 2006, so I guess nobody really cares. But
> > it's simple to fix.
> 
> Heh. It means nobody exercised the codepaths that are inside "if (verbose)",
> so it may uncover old bugs, no?

I thought that at first, too, but actually there is only one code path currently enabled by "verbose", and it is to print "Renaming ...". You can also exercise that code path with "--dry-run" (and the whole path consists of only a single printf, so hopefully we didn't manage to squeeze any bugs in there).

Once upon a time, the verbose flag was passed on to add_file_to_index, but that was dropped when the code switched to using rename_index_entry_at in 81dc230 (git-mv: Keep moved index entries inact, 2008-07-21).

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 7 of 16 in “git 1.7.7.3: BUG - please make git mv -f quiet”
  1. Jari AaltoDec 11, 2011
  2. 0/5 mixed bag of minor "git mv" fixesJeff King, Dec 12, 2011
  3. 1/5 docs: mention "-k" for both forms of "git mv"Jeff King, Dec 12, 2011
  4. Junio C HamanoDec 12, 2011
  5. 2/5 mv: honor --verbose flagJeff King, Dec 12, 2011
  6. Junio C HamanoDec 12, 2011
  7. Jeff KingDec 12, 2011
  8. 3/5 mv: make non-directory destination error more clearJeff King, Dec 12, 2011
  9. Junio C HamanoDec 12, 2011
  10. 4/5 mv: improve overwrite warningJeff King, Dec 12, 2011
  11. Junio C HamanoDec 12, 2011
  12. Jeff KingDec 12, 2011
  13. 4/5 mv: improve overwrite warningJeff King, Dec 12, 2011
  14. 5/5 mv: be quiet about overwritingJeff King, Dec 12, 2011
  15. 5/5 mv: be quiet about overwritingJeff King, Dec 12, 2011
  16. Junio C HamanoDec 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.