git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] mv: honor --verbose flag

From
Jeff King <peff@peff.net>
Date
Dec 12, 2011, 07:51 UTC
Message-ID
<20111212075124.GB17532@sigill.intra.peff.net>
In-Reply-To
<20111212074503.GB16511@sigill.intra.peff.net>

The code for a verbose flag has been here since "git mv" was converted to C many years ago, but actually getting the "-v" flag from the command line was accidentally lost in the transition.

Signed-off-by: Jeff King <peff@peff.net>
---
This has been broken since 2006, so I guess nobody really cares. But
it's simple to fix.
 Documentation/git-mv.txt |    8 ++++++--
 builtin/mv.c             |    1 +
 2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-mv.txt b/Documentation/git-mv.txt
index 4be7a71..e3c8448 100644
--- a/Documentation/git-mv.txt
+++ b/Documentation/git-mv.txt
@@ -15,8 +15,8 @@ DESCRIPTION
 -----------
 This script is used to move or rename a file, directory or symlink.
 
- git mv [-f] [-n] [-k] <source> <destination>
- git mv [-f] [-n] [-k] <source> ... <destination directory>
+ git mv [-v] [-f] [-n] [-k] <source> <destination>
+ git mv [-v] [-f] [-n] [-k] <source> ... <destination directory>
 
 In the first form, it renames <source>, which must exist and be either
 a file, symlink or directory, to <destination>.
@@ -40,6 +40,10 @@ OPTIONS
 --dry-run::
 	Do nothing; only show what would happen
 
+-v::
+--verbose::
+	Report the names of files as they are moved.
+
 GIT
 ---
 Part of the linkgit:git[1] suite
diff --git a/builtin/mv.c b/builtin/mv.c
index 5efe6c5..11abaf5 100644
--- a/builtin/mv.c
+++ b/builtin/mv.c
@@ -59,6 +59,7 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
 	int i, newfd;
 	int verbose = 0, show_only = 0, force = 0, ignore_errors = 0;
 	struct option builtin_mv_options[] = {
+		OPT__VERBOSE(&verbose, "be verbose"),
 		OPT__DRY_RUN(&show_only, "dry run"),
 		OPT__FORCE(&force, "force move/rename even if target exists"),
 		OPT_BOOLEAN('k', NULL, &ignore_errors, "skip move/rename errors"),
-- 
1.7.8.13.g74677
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 16 in “git 1.7.7.3: BUG - please make git mv -f quiet”
  1. Jari AaltoDec 11, 2011
  2. 0/5 mixed bag of minor "git mv" fixesJeff King, Dec 12, 2011
  3. 1/5 docs: mention "-k" for both forms of "git mv"Jeff King, Dec 12, 2011
  4. Junio C HamanoDec 12, 2011
  5. 2/5 mv: honor --verbose flagJeff King, Dec 12, 2011
  6. Junio C HamanoDec 12, 2011
  7. Jeff KingDec 12, 2011
  8. 3/5 mv: make non-directory destination error more clearJeff King, Dec 12, 2011
  9. Junio C HamanoDec 12, 2011
  10. 4/5 mv: improve overwrite warningJeff King, Dec 12, 2011
  11. Junio C HamanoDec 12, 2011
  12. Jeff KingDec 12, 2011
  13. 4/5 mv: improve overwrite warningJeff King, Dec 12, 2011
  14. 5/5 mv: be quiet about overwritingJeff King, Dec 12, 2011
  15. 5/5 mv: be quiet about overwritingJeff King, Dec 12, 2011
  16. Junio C HamanoDec 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.