git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH, v4] git-tag: introduce --cleanup option

From
Jeff King <peff@peff.net>
Date
Dec 5, 2011, 21:51 UTC
Message-ID
<20111205215148.GA22663@sigill.intra.peff.net>
In-Reply-To
<1322972426-7591-1-git-send-email-kirill@shutemov.name>
On Sun, Dec 04, 2011 at 06:20:26AM +0200, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
> 
> Normally git tag stripes tag message lines starting with '#', trailing
> spaces from every line and empty lines from the beginning and end.
s/stripes/strips
> --cleanup allows to select different cleanup modes for tag message.
> It provides the same interface as --cleanup option in git-commit.

Thanks, I think this is better, though it would be better still if they could share the code. As a minor nit, I think the patch would be a little easier to read and review if you split the actual changes from the refactoring to use the "struct create_tag_options".

More importantly, though, this seems to break t6300 badly. I haven't looked into why yet, though.

-Peff
Previous: Kirill A. ShutemovNext: Junio C Hamano
Message 2 of 7 in “git-tag: introduce --cleanup option”
  1. git-tag: introduce --cleanup optionKirill A. Shutemov, Dec 4, 2011
  2. Jeff KingDec 5, 2011
  3. Junio C HamanoDec 5, 2011
  4. Junio C HamanoDec 5, 2011
  5. Kirill A. ShutemovDec 7, 2011
  6. Jeff KingDec 5, 2011
  7. Jeff KingDec 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.