From: Jeff King <peff@peff.net>
Date: Mon, 05 Dec 2011 21:51:48 GMT
Subject: Re: [PATCH, v4] git-tag: introduce --cleanup option
Message-ID: <20111205215148.GA22663@sigill.intra.peff.net>
In-Reply-To: <1322972426-7591-1-git-send-email-kirill@shutemov.name>

On Sun, Dec 04, 2011 at 06:20:26AM +0200, Kirill A. Shutemov wrote:

> From: "Kirill A. Shutemov" <kirill@shutemov.name>
> 
> Normally git tag stripes tag message lines starting with '#', trailing
> spaces from every line and empty lines from the beginning and end.

s/stripes/strips

> --cleanup allows to select different cleanup modes for tag message.
> It provides the same interface as --cleanup option in git-commit.

Thanks, I think this is better, though it would be better still if they
could share the code. As a minor nit, I think the patch would be a
little easier to read and review if you split the actual changes from
the refactoring to use the "struct create_tag_options".

More importantly, though, this seems to break t6300 badly. I haven't
looked into why yet, though.

-Peff