Re: [PATCH] make git-svn resilient to log.abbrevcommit = true

From: Eric Wong <normalperson@yhbt.net>
Date: Nov 24, 2011, 18:32 UTC
Message-ID: <20111124183233.GA22111@dcvr.yhbt.net>
In-Reply-To: <201111241411.05655.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> wrote:

Show 15 quoted lines

> Shahid Alam wrote:
> > Add --no-abbrev-commit arg to working_head_Info()'s invocation
> > of git log.
> [...]
> > @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
> > sub working_head_info {
> > 	my ($head, $refs) = @_;
> > 	my @args = qw/log --no-color --no-decorate --first-parent
> > -	              --pretty=medium/;
> > +	              --no-abbrev-commit --pretty=medium/;
> 
> Undeniably a bug, but to prevent the same from happening again,
> wouldn't it be better to rewrite it using simply
> 
>   rev-list --first-parent --pretty=medium

Yes, I've never been happy with using "git log" for any internals since it's a porcelain. I'll gladly accept a tested patch which uses rev-list instead. Thanks!