Re: [PATCH] make git-svn resilient to log.abbrevcommit = true

From: Thomas Rast <trast@student.ethz.ch>
Date: Nov 24, 2011, 13:11 UTC
Message-ID: <201111241411.05655.trast@student.ethz.ch>
In-Reply-To: <3A78B8F7-803C-4278-8B5F-4A1B02C9FF04@gmail.com>

[add Eric to Cc]

Shahid Alam wrote:

> Add --no-abbrev-commit arg to working_head_Info()'s invocation
> of git log.

[...]

Show 6 quoted lines

> @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
> sub working_head_info {
> 	my ($head, $refs) = @_;
> 	my @args = qw/log --no-color --no-decorate --first-parent
> -	              --pretty=medium/;
> +	              --no-abbrev-commit --pretty=medium/;

Undeniably a bug, but to prevent the same from happening again, wouldn't it be better to rewrite it using simply

  rev-list --first-parent --pretty=medium

-- 
Thomas Rast
trast@{inf,student}.ethz.ch